Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autorotate filter based on exif metadata #318

Merged
merged 1 commit into from
Apr 21, 2014

Conversation

romainneutron
Copy link
Collaborator

No description provided.

@romainneutron
Copy link
Collaborator Author

This should fix #190

romainneutron added a commit that referenced this pull request Apr 21, 2014
Add autorotate filter based on exif metadata
@romainneutron romainneutron merged commit 7687997 into php-imagine:develop Apr 21, 2014
@romainneutron romainneutron deleted the autorotate-filter branch April 21, 2014 16:01
@schmitter
Copy link

I just tested this with iPhone pic - the call to $image->metadata() is not properly presenting the exif "Orientation" key to your filter method. The actual key from the exif_read_data() is presented as simply "Orientation" - whereas your filter is looking for "ifd0.Orientation" from Imagine's metadata method.

@romainneutron
Copy link
Collaborator Author

Can you please provide the file ?

On 25 avr. 2014, at 23:00, schmitter notifications@github.com wrote:

I just tested this with iPhone pic - doesn't appear the call to $image->metadata() is properly presenting the exif "Orientation" key to your filter method.


Reply to this email directly or view it on GitHub.

@schmitter
Copy link

I just took a picture with my iPhone - any would do.

@romainneutron
Copy link
Collaborator Author

Please provide a code snippet, the corresponding image, PHP and driver versions. Otherwise I'm not able to reproduce your issue (I currently get the expected result)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants