Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent attribute names #17

Closed
stantond opened this issue Nov 6, 2020 · 5 comments
Closed

Consistent attribute names #17

stantond opened this issue Nov 6, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@stantond
Copy link

stantond commented Nov 6, 2020

For n attributes, the numbers are consistent, with _ representing the decimal.

For consistently and to make the numbers easier to understand, should the following change?

From To
raw01 raw1
raw25 raw2_5
pm01 pm1
pm25 pm2_5
pm04 pm4
@avaldebe
Copy link
Owner

avaldebe commented Nov 9, 2020

The naming came from work, the Open Source EMEP MSC-W model uses PM25 for PM2.5 and I'm so used to it that pm2_5 looks wrong to me.

I already have 1.5 years collected as pm25 so I won't change the fields names, but I could define raw2_5/pm2_5 as properties for all relevant PM sensors. Would this be sufficient?

@avaldebe avaldebe added the enhancement New feature or request label Nov 9, 2020
@stantond
Copy link
Author

stantond commented Nov 9, 2020

Makes sense if you're confirming to another standard, does Open Source EMEP MSC-W model also present PM1 as PM01 and PM4 as PM04?

@avaldebe
Copy link
Owner

avaldebe commented Nov 9, 2020

Makes sense if you're confirming to another standard, does Open Source EMEP MSC-W model also present PM1 as PM01 and PM4 as PM04?

It only has PM2.5 and PM10 outputs. Some of my colleagues have research versions with more detail but I do not know what they call the extra tracers.

... I could define raw2_5/pm2_5 as properties for all relevant PM sensors. Would this be sufficient?

What do you think about the raw2_5/pm2_5 properties?

@stantond
Copy link
Author

stantond commented Nov 9, 2020

I think that's a good idea to give consistent names without making a breaking a change

@avaldebe
Copy link
Owner

avaldebe commented Nov 9, 2020

I only pushed raw2_5/pm2_5 properties, when I add them all the coverage goes under 95%...
I'll add some tests before pushing the rest

@avaldebe avaldebe reopened this Nov 9, 2020
avaldebe added a commit that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants