Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate video removal #112

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Fix duplicate video removal #112

merged 1 commit into from
Jan 29, 2022

Conversation

dnicolson
Copy link
Contributor

Description

This pull request fixes an issue where duplicate watched videos in a playlist cause a videos missing from UI error.

The listMapSearch method expects a unique list of needles, this ensures duplicates are removed first.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@avallete
Copy link
Owner

Nice one 👍

@avallete avallete merged commit 3001009 into avallete:master Jan 29, 2022
avallete pushed a commit that referenced this pull request Jan 29, 2022
chore(release): 1.5.5 [skip ci]
d7593bc 
## [1.5.5](v1.5.4...v1.5.5) (2022-01-29)

### Bug Fixes

* duplicate video removal ([#112](#112)) ([3001009](3001009))
* video removal event ([#111](#111)) ([aa0dced](aa0dced))
@avallete
Copy link
Owner

🎉 This PR is included in version 1.5.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnicolson @avallete