Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XPath expressions and simplify single video behavior #189

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Update XPath expressions and simplify single video behavior #189

merged 3 commits into from
Nov 14, 2022

Conversation

dnicolson
Copy link
Contributor

Description

This pull request updates the XPath expressions due to YouTube changes. The changes from #104 have been simplified, as if the video count cannot be found or if it is a single video a reload is necessary anyway.

How Has This Been Tested?

Playlists with single and multiple videos were tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dnicolson
Copy link
Contributor Author

Hi @avallete, can you please take a look at this?

@avallete
Copy link
Owner

Hi,

Looks good to me ! Thank you for the contribution.

@avallete avallete added the safe to test Use to start running CI on the PR label Nov 14, 2022
@avallete avallete merged commit 305df3f into avallete:master Nov 14, 2022
avallete pushed a commit that referenced this pull request Nov 14, 2022
…or (#189)

* fix: simplify 1 video playlist behavior

* fix: update Xpath expressions

* fix: update Xpath expressions
avallete pushed a commit that referenced this pull request Nov 14, 2022
## [1.5.9](v1.5.8...v1.5.9) (2022-11-14)

### Bug Fixes

* **xpath:** Update XPath expressions and simplify single video behavior ([#189](#189)) ([a01034b](a01034b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Use to start running CI on the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants