Fix append to DOM #143
Merged
Fix append to DOM #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 52 52
Branches 7 7
=========================================
Hits 52 52 Continue to review full report at Codecov.
|
avallete
approved these changes
Feb 11, 2022
avallete
pushed a commit
that referenced
this pull request
Feb 11, 2022
## [1.5.6](v1.5.5...v1.5.6) (2022-02-11) ### Bug Fixes * append to dom ([#143](#143)) ([a6de26a](a6de26a))
|
🎉 This PR is included in version 1.5.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request delays appending to the DOM until after the
ytd-update-grid-state-actionevent is dispatched.Motivation and Context
Recent changes have resulted in some elements being unavailable on the
DOMContentLoadedevent.How Has This Been Tested?
Manually in Chrome with a custom YouTube playlist.
Types of changes
Checklist: