Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests to write #46

Closed
2 tasks done
grokys opened this issue May 5, 2015 · 7 comments
Closed
2 tasks done

Tests to write #46

grokys opened this issue May 5, 2015 · 7 comments

Comments

@grokys
Copy link
Member

grokys commented May 5, 2015

Random list of tests to write, as I think of them while doing something else...

  • Make sure TabStrip/TabControl first tab is initially selected
  • Make sure TabStrip/TabControl tabs are selected when tabs removed
@Robertofon
Copy link

why don't you assign it to me

@grokys
Copy link
Member Author

grokys commented Jul 22, 2015

I'm currently in the process of refactoring a lot of this stuff, so there's probably not much point right now. I will let you know when the refactoring is complete.

@grokys
Copy link
Member Author

grokys commented Jul 24, 2015

Ok @Robertofon - I've given up on refactoring - if you'd still like to do it, you're welcome!

@Robertofon
Copy link

OK, I'll give a try hopefully tonight....

@grokys
Copy link
Member Author

grokys commented Jul 28, 2015

@Robertofon - if you've not already made a start on this, probably best to hold off - I'm refactoring the ItemsControl based controls again.

@Robertofon
Copy link

Well, summer has too many oportunities. I actually did a look at it and seems like the first half of the thest are already created and working. The removal part seems to miss.

Robertofon pushed a commit to Robertofon/Avalonia that referenced this issue Jul 29, 2015
AvaloniaUI#46 Added remove-Tests for TabStrip and TabControl.
8093543 
TabControl's SelectedContent fails.
@Robertofon
Copy link

Could not resist and created two tests. But it was worth it. Semms like TabControl's SelectedContent does not get updated. I left it for you to decide and then fix.

@grokys grokys closed this as completed Aug 3, 2015
@josegomez josegomez mentioned this issue Apr 13, 2020
Closed
maxkatz6 pushed a commit that referenced this issue Feb 20, 2023
@worldbeater @dependabot
build(deps): Bump Microsoft.CodeAnalysis.CSharp in /src (#46)
93784b7 
* build(deps): Bump Microsoft.CodeAnalysis.Common in /src

Bumps [Microsoft.CodeAnalysis.Common](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0.
- [Release notes](https://github.com/dotnet/roslyn/releases)
- [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md)
- [Commits](dotnet/roslyn@v3.8.0...v3.9.0)

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): Bump Microsoft.CodeAnalysis.CSharp in /src

Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0.
- [Release notes](https://github.com/dotnet/roslyn/releases)
- [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md)
- [Commits](dotnet/roslyn@v3.8.0...v3.9.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Use Microsoft.CodeAnalysis.Common as transitive dependency

* Revert "Use Microsoft.CodeAnalysis.Common as transitive dependency"

This reverts commit 89e5ff5bde4fc84400a5b6340874b50d89f5e4b9.

* Use newer SDK

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grokys @Robertofon