Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11: Section navigation issues #2827

Open
Karthikeya212 opened this issue Feb 13, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@Karthikeya212
Copy link
Collaborator

commented Feb 13, 2018

Issue 1: Autoswitch/Autoplay not working in a multi-section item.

Issue 2: Autoswitch/Autoplay not working in a playlist with multiple items.

Issue 3: Cannot navigate to other items in the playlist by clicking on the item. So, cannot play any other item in the playlist except the first.

@bkeese

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

IE11 is missing support for Array.from (at least). We need to polyfill, or avoid using spread. ( @adamjarling )

Object doesn't support property or method 'from'
plugin_playlist_items.js (24,165)
@bkeese

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

@adamjarling

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

Hmmm. Interesting. So Babel is being brought into the application through the 'sprockets-es6' gem, or whatever it's named. Can a gem be configured? In this case, like to include a polyfill? Or could we install the polyfill code directly into the application, before our application code is rendered?

https://babeljs.io/docs/usage/polyfill

@adamjarling

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

As a test, if you chucked this into the app, does it seem to fix whatever is breaking?

<script src="https://cdnjs.cloudflare.com/ajax/libs/babel-polyfill/6.26.0/polyfill.min.js"></script>

@bkeese

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

Yes. It does solve the problem.

@cjcolvar

This comment has been minimized.

Copy link
Member

commented May 23, 2019

@bkeese @joncameron @davidschober Did this ever get fixed?

@bkeese

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Looks like babel-polyfill is coming in with sme package and also with the timeliner.

@joncameron

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

We'll need to retest this The package is there, and so it might be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.