Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty playlists should display playlist description and tags #5636

Closed
elynema opened this issue Feb 6, 2024 · 2 comments
Closed

Empty playlists should display playlist description and tags #5636

elynema opened this issue Feb 6, 2024 · 2 comments

Comments

@elynema
Copy link
Contributor

elynema commented Feb 6, 2024

Description

Currently, empty playlists simply display a message that reads "This playlist is empty." They should, however, display the playlist description and tags that can be entered when creating the playlist.

Current:

image.png

Prior behavior for an empty playlist:

image.png

@elynema elynema changed the title Empty playlists should display playlist description Empty playlists should display playlist description and tags Feb 6, 2024
@joncameron
Copy link
Contributor

joncameron commented Feb 28, 2024

Tag, comment and description are loaded on the Avalon side. We could change Ramp behavior to display something similar to what we have with inaccessible items: empty div with the message, instead of the alert error. Right now Ramp reads this and crashes, and bubbles up the error (and doesn't show the other parts of the page). We can change this, again to match inaccessible items.

Changes will be on the Ramp side; we can change things there and then see if anything needs to be changed in Avalon for the playlist page.
@joncameron Create an issue in the Ramp repo for this change. (2 points)

@joncameron
Copy link
Contributor

See samvera-labs/ramp#457

@joncameron joncameron closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants