Convert Comment to a hash before passing to mailer, and then to an OpenStruct for processing #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enStruct for processing
|
I believe these tests are failing because the branch was cut from master instead of develop. I cherry picked this commit to a branch cut from develop and created #1791. After it is merged to develop, we should merge it to staging and then to master. |
|
Closing due to #1791 being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1789
ActiveJob can't serialize a
Comment, but it can serialize aHash. By leveragingOpenStruct, we can convert theCommentto aHashfor serializing, and then back to something that quacks like aCommentfor rendering.