Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is support for CommonJS dropped since v4? #71

Closed
ivstiv opened this issue Mar 30, 2023 · 1 comment · Fixed by #72
Closed

Is support for CommonJS dropped since v4? #71

ivstiv opened this issue Mar 30, 2023 · 1 comment · Fixed by #72

Comments

@ivstiv
Copy link

ivstiv commented Mar 30, 2023

I just upgraded to the latest version and got this error:

Error [ERR_REQUIRE_ESM]: require() of ES Module /app/node_modules/.pnpm/paddle-sdk@4.0.0/node_modules/paddle-sdk/esm/sdk.js from /app/dist/utilities/paddle.js not supported.

I am not asking for a fix, just checking what the intention of the major upgrade is, since the change log doesn't acknowledge dropping of CJS support.
@avaly
Copy link
Owner

avaly commented Mar 30, 2023

It's definitely not intentional. I'll fix this bug and deploy a fix version later today.

@avaly avaly mentioned this issue Mar 30, 2023
Merged
@avaly avaly closed this as completed in #72 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix CommonJS and ESM exports avaly/paddle-sdk
2 participants
@avaly @ivstiv