Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install .pyenvrc fails if owner != group #15

Open
angusmci opened this issue Mar 31, 2018 · 6 comments
Open

Install .pyenvrc fails if owner != group #15

angusmci opened this issue Mar 31, 2018 · 6 comments

Comments

@angusmci
Copy link

The 'Install .pyenvrc' task assumes that 'owner' and 'group' have the same name, specified by variable 'pyenv_owner'. If a group with the same name as the owner does not exist on the host, the install will fail with "chgrp failed: failed to look up group"

@avanov
Copy link
Owner

avanov commented May 16, 2018

Confirmed, will work on that

@avanov
Copy link
Owner

avanov commented May 16, 2018

On the other hand, I'm thinking whether pyenv should ever be allowed for other groups but the one associated with the user when it is installed in a non-privileged user mode. And even if that group doesn't exist by default, maybe it's worth to create it outside the pyenv role instead of allowing a different group within the role.

@angusmci
Copy link
Author

It seems reasonable to limit it to the group (or groups?) that the user is associated with ... but it looked to me as if the role required the group to have the exact same name as the user, which probably won't always be the case.

@avanov
Copy link
Owner

avanov commented May 16, 2018

but it looked to me as if the role required the group to have the exact same name as the user

yes, it is the current implementation

@avanov
Copy link
Owner

avanov commented May 16, 2018

@angusmci I've updated the trunk, does it look reasonable for you?

@angusmci
Copy link
Author

Seems reasonable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants