Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency on redundant session_answers table + optimized some mongo queries #84

Merged
merged 5 commits into from
Apr 5, 2023

Conversation

deepansh96
Copy link
Member

@deepansh96 deepansh96 commented Mar 28, 2023

Copy link
Contributor

@pritamps pritamps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just questions for my own context building!

app/routers/session_answers.py Show resolved Hide resolved
app/routers/session_answers.py Show resolved Hide resolved
app/routers/session_answers.py Outdated Show resolved Hide resolved
@deepansh96 deepansh96 temporarily deployed to Staging April 1, 2023 06:40 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 81.25% and project coverage change: -1.07 ⚠️

Comparison is base (f970b54) 95.55% compared to head (35ca665) 94.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   95.55%   94.48%   -1.07%     
==========================================
  Files          16       16              
  Lines         697      707      +10     
==========================================
+ Hits          666      668       +2     
- Misses         31       39       +8     
Impacted Files Coverage Δ
app/models.py 100.00% <ø> (ø)
app/routers/sessions.py 84.15% <72.72%> (-4.98%) ⬇️
app/routers/session_answers.py 86.66% <85.71%> (-6.89%) ⬇️
app/tests/test_session_answers.py 100.00% <100.00%> (ø)
app/tests/test_sessions.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants