-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial marking #110
Merged
Merged
Partial marking #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 72.64% 73.10% +0.45%
==========================================
Files 54 57 +3
Lines 6694 6792 +98
Branches 632 632
==========================================
+ Hits 4863 4965 +102
+ Misses 1820 1816 -4
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relevant ADR: https://www.notion.so/avantifellows/ADR-Partial-Marking-and-Sections-For-Jee-Adv-f40af250e44140968ae513e43a03bac4
Test Plan
Local Language SupportCheck for bundle size here if adding a packageAdded relevant details like Labels/Projects/Milestones etc.If adding or removing any environment variable, updatedocs/ENV.md
,.env.example
and the Github workflows.Images havealt
attributesAny<img>
tags havewidth
andheight
specifiedAnytarget="_blank"
links haverel="noopener"
Only SVGs are used as images. If PNGs are used, their size has been optimised.Any SVG buttons without text have theiraria-label
attributes set