Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial marking #110

Merged
merged 37 commits into from
May 22, 2023
Merged

Partial marking #110

merged 37 commits into from
May 22, 2023

Conversation

suryabulusu
Copy link
Collaborator

@suryabulusu suryabulusu commented May 7, 2023

Summary

  • Allows partial marking for multi-choice questions
  • UI changes to display partial mark key in palette and scorecard
  • Adds description to palette which contains question set's question type and marking scheme information
  • Adds tests to check partial marking

Relevant ADR: https://www.notion.so/avantifellows/ADR-Partial-Marking-and-Sections-For-Jee-Adv-f40af250e44140968ae513e43a03bac4

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
  • [] Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable, update docs/ENV.md, .env.example and the Github workflows.
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVG buttons without text have their aria-label attributes set

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Patch coverage: 69.36% and project coverage change: +0.45 🎉

Comparison is base (054d292) 72.64% compared to head (1af8d80) 73.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   72.64%   73.10%   +0.45%     
==========================================
  Files          54       57       +3     
  Lines        6694     6792      +98     
  Branches      632      632              
==========================================
+ Hits         4863     4965     +102     
+ Misses       1820     1816       -4     
  Partials       11       11              
Flag Coverage Δ
chrome 73.10% <69.36%> (+0.45%) ⬆️
ui 78.98% <83.33%> (+0.84%) ⬆️
unittest 69.24% <61.84%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/services/Functional/Utilities.ts 41.66% <0.00%> (-0.22%) ⬇️
src/views/Player.vue 29.61% <20.63%> (+1.44%) ⬆️
src/components/Omr/OmrModal.vue 87.41% <100.00%> (ø)
src/components/Questions/Palette/Item.vue 100.00% <100.00%> (ø)
...rc/components/Questions/Palette/PartialSuccess.vue 100.00% <100.00%> (ø)
...c/components/Questions/Palette/QuestionPalette.vue 100.00% <100.00%> (ø)
src/components/Scorecard.vue 94.49% <100.00%> (-0.90%) ⬇️
src/components/UI/Icons/BaseIcon.vue 100.00% <100.00%> (ø)
src/components/UI/Icons/PartiallyCorrect.vue 100.00% <100.00%> (ø)
...rc/components/UI/Icons/PartiallyCorrectRounded.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@suryabulusu suryabulusu temporarily deployed to Staging May 8, 2023 22:07 — with GitHub Actions Inactive
@suryabulusu suryabulusu temporarily deployed to Staging May 9, 2023 06:52 — with GitHub Actions Inactive
@suryabulusu suryabulusu temporarily deployed to Staging May 9, 2023 06:56 — with GitHub Actions Inactive
@suryabulusu suryabulusu temporarily deployed to Staging May 19, 2023 21:12 — with GitHub Actions Inactive
@suryabulusu suryabulusu temporarily deployed to Staging May 22, 2023 19:16 — with GitHub Actions Inactive
@suryabulusu suryabulusu merged commit 852bc50 into main May 22, 2023
8 of 9 checks passed
@suryabulusu suryabulusu deleted the partial_marking branch May 22, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants