Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] event_track_analytic: Event track state equal done create analy… #1089

Merged
merged 1 commit into from
May 12, 2021
Merged

[IMP] event_track_analytic: Event track state equal done create analy… #1089

merged 1 commit into from
May 12, 2021

Conversation

Berezi
Copy link
Contributor

@Berezi Berezi commented May 3, 2021

…tic line.

@codecov
Copy link

codecov bot commented May 3, 2021 •
edited

Codecov Report

Merging #1089 (3dc17dc) into 14.0 (5ed6afd) will decrease coverage by 11.78%.
The diff coverage is 21.42%.

❗ Current head 3dc17dc differs from pull request most recent head 260a4b4. Consider uploading reports for the commit 260a4b4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             14.0    #1089       +/-   ##
===========================================
- Coverage   92.95%   81.17%   -11.79%     
===========================================
  Files          12       12               
  Lines          71       85       +14     
===========================================
+ Hits           66       69        +3     
- Misses          5       16       +11
Impacted Files Coverage Δ
...ent_track_analytic/models/account_analytic_line.py 77.77% <ø> (ø)
event_track_analytic/models/event_track.py 45.00% <21.42%> (-55.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed6afd...260a4b4. Read the comment docs.

@Berezi Berezi force-pushed the odoo-addons14-event_track_analytic branch 2 times, most recently from 664f9ad to ef4ee49 Compare May 5, 2021 09:44
alfredoavanzosc
alfredoavanzosc approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@alfredoavanzosc alfredoavanzosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Berezi Berezi force-pushed the odoo-addons14-event_track_analytic branch from ef4ee49 to 260a4b4 Compare May 7, 2021 11:05
@Berezi
Copy link
Contributor Author

Berezi commented May 7, 2021

@anajuaristi @Daniel-CA @oihane @alfredoavanzosc review please.

@alfredoavanzosc alfredoavanzosc merged commit 02752f1 into avanzosc:14.0 May 12, 2021
@Berezi Berezi deleted the odoo-addons14-event_track_analytic branch May 12, 2021 08:08
oihane pushed a commit to oihane/odoo-addons that referenced this pull request Jun 30, 2021
@Berezi @oihane
[IMP] event_track_analytic: Event track state equal done create analy…
dc01e9e 
…tic line. (avanzosc#1089)

Co-authored-by: Tu Nombre <you@example.com>
oihane pushed a commit to Berezi/odoo-addons that referenced this pull request Sep 25, 2023
@Berezi @oihane
[IMP] event_track_analytic: Event track state equal done create analy…
46ae47f 
…tic line. (avanzosc#1089)

Co-authored-by: Tu Nombre <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anajuaristi anajuaristi anajuaristi approved these changes

@Daniel-CA Daniel-CA Daniel-CA approved these changes

@alfredoavanzosc alfredoavanzosc alfredoavanzosc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Berezi @anajuaristi @Daniel-CA @alfredoavanzosc