Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppleRGB color correction for classic-era resources #221

Merged
merged 19 commits into from
Sep 6, 2022

Conversation

rherriman
Copy link
Member

Closes #218

@rherriman
Copy link
Member Author

This is currently blocked by larger issues with BSPs, requiring a rewrite of bspt.py. Perhaps we should revert the bsp changes for now and merge what is ready?

assertivist and others added 8 commits September 5, 2022 01:28
…uts more correct face data based on input normals - ran converter against all shapes and levels - updated json.hpp to new version - refactored bspt.py, applergb.py, AvaraGL.cpp - fixed shaders - BSPViewer updates
set number of make jobs to 2 for CI
@assertivist
Copy link
Member

I was able to refactor bspt.py successfully and the model fixes are now merged with the color correction fixes.
Fixes #210 #81 and #221

@assertivist assertivist merged commit 57e171c into main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color values used directly from PICT resources are subtly darker (incorrect gamma)
2 participants