WIP: Fix tests after calling fixture functions directly became an error\ #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because docker_ip is a session scoped fixture, to reset it we need to run it in an isolated test session every time.
|
Hello @butla! |
|
Ok, roger that. I had some ideas in my personal backlog, but never got the time to implement them. And I probably won't have that time now, cause nowadays I'm just keeping Compose running in the background all the time instead of using pytest-docker to put it up and close it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress, cause I only fixed one file.
I'm not sure if I should carry on with this fix, though, cause the other broken file -
test_docker_services.pyhas brittle, mock-ridden tests, which I would gladly replace with some functional tests that don't rely on mocking.