-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow container re-use #67
Conversation
If the spawn and cleanup commands are skipped by overriding the fixture commands to "", None, or False then existing containers can be left around.
Ugh, I should have looked for PRs earlier, this is a dupe of #64 |
Hello, I have a couple of changes I would like to make but I'm unable to push them. I think I need permissions on your fork for that. Could you please grant me those? |
Closes #63 |
Closes #54 |
Sure thing! Im on mobile right now, ill update to allow edits today. Sorry, its been a busy few days i did not see this. Thank you! |
Huh I have this set to allow edits from you. What would you like changed? |
I'm not able to push to your branch for some reason. Maybe I'm doing something wrong. |
Awesome! Im sure its fine, ill get it merged today for you. Thanks! |
Ping, @raddessi |
Sorry, i see this every day i just havent got time for it. Busy week. I may today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me :) Thank you and sorry for the delay
If the spawn and cleanup commands are skipped by overriding the fixture
commands to "", None, or False then existing containers can be left
around.
Having this as a native feature would be much cleaner than how I'm currently managing this. Thank you for all the work on this project, I've used it in many others with great success :)