Make container scopes configurable #91

austinkeller · 2023-01-25T07:12:48Z

Resolves #89

gipi · 2023-11-29T15:54:26Z

src/pytest_docker/plugin.py

+
+
+def containers_scope(fixture_name, config):
+    return config.getoption("--containers-scope-fixture")


probably a typo?

gipi · 2023-11-29T15:55:24Z

src/pytest_docker/plugin.py

@@ -29,6 +29,25 @@ def execute(command, success_codes=(0,)):
    return output


+def pytest_addoption(parser):


I think you need to import this somewhere otherwise it's not "parsed" and seen by pytest, because for me it's not working otherwise

gipi · 2023-11-29T15:55:29Z

src/pytest_docker/plugin.py

@@ -29,6 +29,25 @@ def execute(command, success_codes=(0,)):
    return output


+def pytest_addoption(parser):


I think you need to import this somewhere otherwise it's not "parsed" and seen by pytest, because for me it's not working otherwise

augi · 2024-01-25T10:53:00Z

IMHO implemented in another PR that has just been closed.

Make container scopes configurable

9c186ef

gipi reviewed Nov 29, 2023

View reviewed changes

src/pytest_docker/plugin.py

def containers_scope(fixture_name, config):

return config.getoption("--containers-scope-fixture")

Copy link

gipi Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a typo?

gipi reviewed Nov 29, 2023

View reviewed changes

n1ngu mentioned this pull request Jan 24, 2024

Make container scopes configurable fix solution #103

Merged

augi closed this Jan 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make container scopes configurable #91

Make container scopes configurable #91

austinkeller commented Jan 25, 2023

gipi Nov 29, 2023

gipi Nov 29, 2023

gipi Nov 29, 2023

augi commented Jan 25, 2024



		def containers_scope(fixture_name, config):
		return config.getoption("--containers-scope-fixture")

		@@ -29,6 +29,25 @@ def execute(command, success_codes=(0,)):
		return output


		def pytest_addoption(parser):

Make container scopes configurable #91

Make container scopes configurable #91

Conversation

austinkeller commented Jan 25, 2023

gipi Nov 29, 2023

Choose a reason for hiding this comment

gipi Nov 29, 2023

Choose a reason for hiding this comment

gipi Nov 29, 2023

Choose a reason for hiding this comment

augi commented Jan 25, 2024