Five regression tests concerning parsing of Mach-O via fileinfo are failing with the Debug build

[s3rvac]

Five regression tests concerning parsing of Mach-O via fileinfo are failing with the Debug build of RetDec.

Steps to reproduce

1. Build the current master of RetDec in the Debug mode.
2. Run our regression tests.

Expected output

SUCCESS (5407/5407)

Actual output

FAIL (failed 5 out of 5407 tests)

The failed tests are:

tools.fileinfo.bugs.macho-bad-alloc-2.Test (564ee59caad056d98ed274c8c4f06e82 --json --verbose)      [ FAIL ]  (0.10s)
tools.fileinfo.features.better-delphi-detection.TestDelphi19 (macho-ios-sim --json)                 [ FAIL ]  (0.09s)
tools.fileinfo.features.better-delphi-detection.TestMachODelphi16 (macho-simulator --json)          [ FAIL ]  (0.09s)
tools.fileinfo.features.better-delphi-detection.TestMachODelphi16 (macho-simulator --json)          [ FAIL ]  (0.09s)
tools.fileinfo.features.better-delphi-detection.TestMachODelphi18 (macho-simulator --json)          [ FAIL ]  (0.09s)
tools.fileinfo.loader.bugs.macho-section-no-associated-segment.Test (COD4-Advantage-Tool --js[..])  [ FAIL ]  (0.12s)

Notes

• All failures are related to parsing of Mach-O binaries.
• The tests succeed when being run with a Release build of RetDec. Only the Debug build is failing.
• When dealing with this issue, please also take a look at fileinfo fails with an unhandled error "inconsistant export info size" in fileformat::MachOFormat::initStructures() #561 and fileinfo fails with an unhandled error "bad library ordinal" in fileformat::MachOFormat::initStructures() #568 which probably have the same cause.
• Here is the output from retdec-fileinfo for the binary file from the first of the failing tests:

  $ ./retdec-fileinfo 564ee59caad056d98ed274c8c4f06e82
  Program aborted due to an unhandled Error:
  truncated or malformed object (export info size: 0x530 in export trie data at node: 0x0 too big and extends past end of trie data)Aborted
  

• My guess is that this is caused by the update of LLVM from 3.9 to 8.0.
• We should consider running a Debug build of RetDec in TeamCity to detect such issues more early.

Configuration

• Commit: 3832eb1 (current master)
• OS:
  • 64b Arch Linux, GCC 8.3.0, Debug build of RetDec, or
  • 64b Debian Linux, GCC 6.3.0, Debug build of RetDec

[s3rvac]

I can confirm that the issue has started since the update to LLVM 8.0:

7a2018bb4dce191242cd7382390993ff6a8ab865 (first commit with LLVM 8.0)   FAIL
c63cc93a6e1f64cb5569ca167a5a29c0d24f9d68 (last commit with LLVM 3.9)    OK