Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE signature needs to be outside of the image to be considered valid #972

Closed
metthal opened this issue Jun 16, 2021 · 1 comment · Fixed by #986
Closed

PE signature needs to be outside of the image to be considered valid #972

metthal opened this issue Jun 16, 2021 · 1 comment · Fixed by #986

Comments

@metthal
Copy link
Member

metthal commented Jun 16, 2021

Signatures in PE files needs to be outside of the image to be considered valid. These files contain signatures in their last section and Windows doesn't see them at all. Please make it so that this is actually checked for.

026ca63f4f1364726b32af8d6e628172dcffc36405c4e09a140bf422045c743b
c4b9677e1a4795d99a18354771a32b50574c1e74df8393828d26f922bac1c8ef
@HoundThe
Copy link
Member

HoundThe commented Jul 9, 2021

I am thinking about how to include this in the output, that the signature is outside of the image and thus invalid. Would an extra "isValid" member be sufficient or maybe something more specific "isOutsideImage"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants