Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wget flag to reset connection #6

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Conversation

Manouchehri
Copy link
Contributor

@Manouchehri Manouchehri commented Dec 13, 2017

Since install-sh.sh is a part of the install process, we probably don't want to wait for the long default of 15 minutes (bcbio/bcbio-nextgen#1487).

Was having issues on my build box before applying this change (connections to *.s3.amazonaws.com kept hanging).

@s3rvac s3rvac self-requested a review December 17, 2017 15:36
@s3rvac s3rvac self-assigned this Dec 17, 2017
@s3rvac
Copy link
Member

s3rvac commented Dec 17, 2017

Thank you for the suggestion. I agree that setting --read-timeout to a lower-than-default value may be desirable. However, do we really want it to be set to a single second? Shouldn't we set it to, say, 10 seconds? Otherwise, if there is ever a one-second read delay during the download process, the entire download gets restarted. That seems pretty harsh to me :-).

@Manouchehri
Copy link
Contributor Author

Done.

@s3rvac
Copy link
Member

s3rvac commented Dec 18, 2017

Thank you. Could you please squash all the commits together and base the resulting commit on the current origin/master?

@Manouchehri
Copy link
Contributor Author

Done!

@s3rvac
Copy link
Member

s3rvac commented Dec 19, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants