Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps/yaracpp: update reference to yaracpp version that uses xcrun. #611

Merged
merged 1 commit into from Jul 9, 2019
Merged

deps/yaracpp: update reference to yaracpp version that uses xcrun. #611

merged 1 commit into from Jul 9, 2019

Conversation

PeterMatula
Copy link
Collaborator

Fix #439.

@PeterMatula PeterMatula requested a review from s3rvac July 9, 2019 11:15
@PeterMatula
Copy link
Collaborator Author

@s3rvac will you please merge this if CIs pass?

@s3rvac
Copy link
Member

s3rvac commented Jul 9, 2019

Sure.

@s3rvac s3rvac self-assigned this Jul 9, 2019
s3rvac
s3rvac approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the builds have succeeded, so I am going to merge this.

@s3rvac s3rvac merged commit 3d3c0f4 into master Jul 9, 2019
@s3rvac s3rvac deleted the issue-439 branch July 9, 2019 12:05
@s3rvac s3rvac mentioned this pull request Jul 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rvac s3rvac s3rvac approved these changes

Assignees

@s3rvac s3rvac

Labels
bug C-build-system O-macos P-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to build with Xcode 10 on macOS Mojave, openssl and yaracpp issue
2 participants
@PeterMatula @s3rvac