Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

location: Unify location.h header files #118

Merged
merged 1 commit into from
Aug 3, 2020
Merged

location: Unify location.h header files #118

merged 1 commit into from
Aug 3, 2020

Conversation

MatejKastak
Copy link
Member

  • this PR removes duplicated header file location.h, I don't think there is reason to keep both

Running on current master

> diff include/yaramod/parser/location.h include/yaramod/types/location.h; echo $status
0
  • I chose to keed include/yaramod/parser/location.h because Location is more related to the parser part, in my opinion

TadeasKucera
TadeasKucera approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@TadeasKucera TadeasKucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing and correctly removing the file. I missed this duplicity completely.
LGTM

@TadeasKucera TadeasKucera merged commit b9d9595 into avast:master Aug 3, 2020
@MatejKastak MatejKastak deleted the unify_location_h branch August 3, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TadeasKucera TadeasKucera TadeasKucera approved these changes

Assignees

@metthal metthal

Labels
C-core C-parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MatejKastak @TadeasKucera @metthal