Token locations python bindings #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatejKastak
force-pushed
the
token_locations
branch
4 times, most recently
from
7f1a4f4
to
ccdde60
Compare
In order to preserve backwards compatibility the `line_number` property has been kept, but will be deprecated. Now any other `Location` instance will include `line_number`, that should not be mentioned in the documentation.
MatejKastak
force-pushed
the
token_locations
branch
from
ccdde60
to
5e6dc9c
Compare
MatejKastak
force-pushed
the
token_locations
branch
from
402ce39
to
a8cdf96
Compare
|
First of all thank you for the PR and for recognizing the problems with location of some tokens. The code is alright and I approve it. As for the first checkbox: Please do open a separate pull request for it. |
TadeasKucera
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to access locations of various objects in yara files from python.
Interface
locationis now represented as a structure instead ofstd::pairRule::Locationinterface,line_numberandfile_pathTokenTypefor eachTokenStringinterface to providelocationattribute just like the rulesRule-token_first,token_lastString-token_first,token_last,token_id,token_assignTODO
TokenTypeto cpp11 styleenum classenums, I reverted them because I think they are out of the scope of this PR, if you want I can open a separate PR for just this. What do you think about this change?FIXME:comments. Keep in mind that the values in the tests are my expectations, I you think they are not right we can discuss the changes.