Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YaraFileBuilder recheck with custom modules #166

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Fix YaraFileBuilder recheck with custom modules #166

merged 2 commits into from
Jun 3, 2021

Conversation

TadeasKucera
Copy link
Contributor

@TadeasKucera TadeasKucera commented Jun 2, 2021 •
edited
Loading

This PR fixes a problem of YaraFileBuilder::get method, which when given recheck=True did not use any custom provided modules in the YaraFileBuilder::_module_pool attribute of the particular YaraFileBuilder instance.

  • Add failing test reproducing the problem
  • Fix the problem

@TadeasKucera TadeasKucera self-assigned this Jun 3, 2021
@TadeasKucera TadeasKucera marked this pull request as ready for review June 3, 2021 05:49
TadeasKucera
TadeasKucera commented Jun 3, 2021
View reviewed changes
Copy link
Contributor Author

@TadeasKucera TadeasKucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the test shows, the PR solves precisely the problem which occured.

@TadeasKucera TadeasKucera merged commit af40435 into master Jun 3, 2021
@TadeasKucera TadeasKucera deleted the fix_file_builder_get_recheck branch June 3, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TadeasKucera TadeasKucera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@TadeasKucera