Double always with decimal

[xbabka01]

Hi, this is fix of bug which ocured when you wanted to create double value without decimal (example 10.0). Yaramod in this case generated int instead of double in result

Before

yaramod.double_val(10.0).get().get_text() == '10'

now

yaramod.double_val(10.0).get().get_text() == '10.0'

[MatejKastak]

I was playing a bit more with the numToStr function and how to make it work without adding a new argument. What do you think about this approach? I don't think there are cases when you want to have numToStr(0.0) == "0", you should not get the expected value only if you pass in some hidden flag. Considering the backward compatibility I think this should fall into "fix" category?

template <typename T>
std::string numToStr(const T num, std::ios_base &(*format)(std::ios_base&) = std::dec, bool showbase = false, bool toUpper = false)
{
	std::ostringstream os;

	os << format;

	if (toUpper)
		os << std::uppercase;

	if (showbase)
		os << std::showbase;

	os << num;

	if (std::is_floating_point<T>::value && std::floor(num) == num)
		os << ".0";

	return os.str();
}

After some tests I wonder what we should do in cases when the precision is not sufficient. By default the max precision is 6 decimal spaces, according to docs. But if you want to create a floating point number 0.1234567 the last number is truncated in the resulting rule. Maybe its out of the scope for this PR.

Wrapping up.

Sadly, I have no explicit approval for this PR. I am still curious what do others and you think about the proposed changes.

[MatejKastak]

This feels a little cryptic for me.

• which of this flags is relevant for this call?
• which of this is just to satisfy defaults?

However, using this implementation I don't know how to make this better.

[xbabka01]

Yeah, it is. I changed numToStr as you suggested to automatically detect floating type instead of using flag

[xbabka01]

After some tests I wonder what we should do in cases when the precision is not sufficient. By default the max precision is 6 decimal spaces, according to docs. But if you want to create a floating point number 0.1234567 the last number is truncated in the resulting rule. Maybe its out of the scope for this PR.

Yeah I saw that issue #177 and tried to fix it but it broken multiple other tests see this. From that I came to the conclusion that it would be better to discuss with what precision yaramod should work. And as you mentioned it is not probably out of scope of this PR

[xbabka01]

Precision if fixed in commit e580ffc (#177)

[metthal]

LGTM