Make empty strings section invalid #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TadeasKucera
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Thank you for this PR, it does precisely what your description says. By adding one non-terminal symbol to the grammar you postpone the possibility to generate empty word from the non-terminal strings_body_nonempty. It is correct and I will merge it. I will also make some cosmetics changes immediately after merge, because we are used to put the semicolon on a new line in the grammar definition. Thank you very much!
|
Glad i could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small PR from me. This time I've tackled #141.
After merging this, empty
strings:section won't be allowed. I achieve this by adding a new rule forstrings_body_nonemptythat cannot be empty, and using it instead ofstrings_bodyin the main derivation.This is not related to any issue with mquery, but saw that issue on the issue list and figured I can try to solve it. I realise it's very low priority, but probably also won't hurt.
fixes: #141