Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment_behind and comment_before_token to Expression builder #194

Merged
merged 4 commits into from
Mar 10, 2022

Conversation

TadeasKucera
Copy link
Contributor

@TadeasKucera TadeasKucera commented Jan 18, 2022

Solution of #195. Add commentBehind and comment methods of YaraExpressionBuilder. Add commentBeforeToken, commentBehind and comment methods of TokenStream. Enable nice commenting of conjunctions and disjunctions, see modified tests for demonstration.

@TadeasKucera TadeasKucera marked this pull request as ready for review March 7, 2022 20:52
Copy link
Member

@metthal metthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow describe it also in the documentation please?

@TadeasKucera
Copy link
Contributor Author

Done.

@metthal metthal merged commit e17198e into master Mar 10, 2022
@metthal metthal deleted the comment_at_end_of_condition branch March 10, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make commenting of builded Expressions more flexible.
2 participants