Python type stubs #235
Merged
Python type stubs #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasssadar
force-pushed
the
python_type_stubs
branch
from
109af4d
to
7b6965d
Compare
Tasssadar
force-pushed
the
python_type_stubs
branch
from
7b6965d
to
34da182
Compare
Tasssadar
commented
Jan 25, 2023
MatejKastak
approved these changes
Jan 25, 2023
metthal
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Requires #234)
This is my attempt to add at least some support for code completion and type checking to yaramod.
The initial
.pyifile is generated bystubgen, but the generated output did not even have correct syntax, so I had to make some manual adjustments and I also added some more types while at it - the PR is split into multiple commits on purpose, so you can see the diff between generated output and what actually works.I changed the build scripts to include the needed
.pyiandpy.typedfile. I'm not sure I will not break anything for existing uses of yaramod, especially in projects that already usemypy, so this should definitely be at least a minor version bump.