deps/pog/deps: propagate cxx flags to pog's deps #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate CXX flags to pogs's deps.
I'm not sure, if this is the best solution, or if it is general enough. I need something like this in order to build yaramod with static windows runtime. When I include yaramod in RetDec as an external project, I can pass it
CMAKE_CXX_FLAGS_RELEASEcontaining/MTinstead of/MD. This nearly works, but without this proposed modification, flags do not get propagated to pog's dependencies: fmt and re2.With this it seems to work.
A better solution would be to add some yaramod option that would enable static runtime build. But some kind of propagation to deps would be probably needed anyway, so it can be the next step.