Improve links between individual constructs in internal representation (issue #73) #96
Conversation
…mport of symbol.h from literal.h
…inition so renaming will be easier.
| namespace yaramod { | ||
|
|
||
| ///< Type of the expression. | ||
| enum class ExpressionType |
There was a problem hiding this comment.
What was the motivation for taking out this type out of Expression itself?
There was a problem hiding this comment.
The Literal class now needs to access Symbol::getName method. That means it needs to include the symbol.h file. In the symbol.h file there has been include of expression.h so we would end up with cyclic dependency (see picture). Luckily, the Symbol class only needs access to ExpressionType which has been extracted from Expression::Type to avoid this cyclic dependency.
| else if (literal.isSymbol()) | ||
| os << literal.getSymbol()->getName(); | ||
| else if (literal.isLiteralReference()) | ||
| { |
There was a problem hiding this comment.
Nitpick: there are no curly braces in other parts of this condition so I wouldn't expect them here either.
There was a problem hiding this comment.
I will fix it in my next PR, thank you for merging this.
In this PR we allow
yaramod::Literalto reference another of it's kind so we can create links between tokens in a tokenstream. This brings a possibility to rename strings and rules easily. We had to moveyaramod::Token::Typeto a new file and make it a classyaramod::TokenTypeand similar withyaramod::Expression::Type.