Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about case sensitivity? #7

Open
Richomuffin opened this issue Apr 20, 2018 · 3 comments
Open

What about case sensitivity? #7

Richomuffin opened this issue Apr 20, 2018 · 3 comments
Labels
question Further information is requested

Comments

@Richomuffin
Copy link

The example clip shows the message coming back in lower case, when it was encoded with Sentence Case?

@avastmick avastmick added the question Further information is requested label Apr 20, 2018
@avastmick
Copy link
Owner

This is correct, and intentional. The cipher-one code does not retain case in the encode/decode cycle. Please note, many classical ciphers are case insensitive.

The objective of the repo is to walk through from a starting point of a simple substitution cipher (as created by a 9-year-old) through a number of examples that fix issues with the implementation. cipher-one has key limitations as per the original cipher, these are alleviated in cipher-two, and further still in cipher-three. The latter fixes the case sensitivity issue.

Hope that makes sense.

If you are interested in contributing, that would be great. Documentation or code appreciated.

@Richomuffin
Copy link
Author

Richomuffin commented Apr 20, 2018 via email

@avastmick
Copy link
Owner

Ha ha! Right, I know two Richs in Welly, both equally capable of sucking me into the same (elaborate) gag. I'll put chips on Bremford, because cat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants