Add AVR Support to avatar-qemu for use in HALucinator. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds AVR Support to avatar-qemu. In theory, any AVR is supported. In practice we have only tested this with CPU Models avr5-avr-cpu, avr51-avr-cpu and avr6-avr-cpu. AVR has a strange representation in QEMU, using words and not bytes. Thus the entry point needs to be divided by two compared to its byte-representation. Signed-off-by: Antony Vennard <antony@vennard.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I'm submitting a PR for the AVR supporting code we've been carrying in our fork on top of qemu-6.2, as I'd like this to not disappear or require me to rebase as new qemus arrive.
The code to support it is reasonably straightforward. The only complexity is that QEMU internally exposes and considers the PC register in terms of words, i.e. 2-byte instructions it will execute. Since we, and most of the rest of the world, typically talk about entry points in bytes, we have to do a quick shift in order to convert what is supplied from reading the firmware image.
This only really gets the CPU booted. Other nice features of Avatar aren't included here.
I have corresponding support in avatar2 proper integrated also. However, step at a time.
Happy to leave this open as long as we need to iterate over it to get it merged!