code correction after review

avdev4j · Jun 28, 2019 · ce3b47e · ce3b47e
1 parent 3f76cc7
commit ce3b47e
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lib/utils/object_utils.js b/lib/utils/object_utils.js
@@ -44,9 +44,17 @@ function merge(object1, object2) {
   };
 }
 
+function removeEntriesWithUndefinedValue(entity) {
+  Object.keys(entity).forEach(key => {
+    if (entity[key] === undefined) {
+      delete entity[key];
+    }
+  });
+}
+
 function areEntitiesEqual(firstEntity, secondEntity) {
-  Object.keys(firstEntity).forEach(key => firstEntity[key] === undefined && delete firstEntity[key]);
-  Object.keys(secondEntity).forEach(key => secondEntity[key] === undefined && delete secondEntity[key]);
+  removeEntriesWithUndefinedValue(firstEntity);
+  removeEntriesWithUndefinedValue(secondEntity);
   if (
     firstEntity.fields.length !== secondEntity.fields.length ||
     firstEntity.relationships.length !== secondEntity.relationships.length ||