Refactor to move more builder methods out into Command classes

[samnang]

See #11

I have moved all of builder's methods into commands except black_hole because it's so simple 1 line, so that's why I'm not sure it worths to move it or not?

[coveralls]

Coverage remained the same when pulling 25990b3 on samnang:move_builder_methods_into_commands into 0869d4a on avdi:master.

[samnang]

Is it better to have attr_reader for @class_to_mimic and @include_super?

[avdi]

I'd say yes. The closer the #call method contents is to the extracted method's contents the happier I am.

[avdi]

Thanks for this, this is really helpful. Do you mind making the inline-noted changes?

[coveralls]

Coverage remained the same when pulling a49f5b7 on samnang:move_builder_methods_into_commands into 0869d4a on avdi:master.

[samnang]

what do you think by reducing some nested scopes to be this instead?

module Naught::NullClassBuilder::Commands
  class Traceable < Naught::NullClassBuilder::Command
    # ...
  end 
end

[avdi]

Fine with me.

On Sun, Jul 28, 2013 at 12:17 PM, Samnang Chhun notifications@github.comwrote:

In lib/naught/null_class_builder/commands/traceable.rb:

@@ -0,0 +1,24 @@
+require 'naught/null_class_builder/command'
+
+module Naught

• class NullClassBuilder
• module Commands

•  class Traceable < Naught::NullClassBuilder::Command
  

what do you think by reducing some nested scopes to be this instead:

module Naught::NullClassBuilder::Commands
class Traceable < Naught::NullClassBuilder::Command
# ...
end end

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/34/files#r5440295
.

Avdi Grimm
http://avdi.org

I only check email twice a day. to reach me sooner, go to
http://awayfind.com/avdi

[coveralls]

Coverage remained the same when pulling 2dc6e30 on samnang:move_builder_methods_into_commands into 0869d4a on avdi:master.

[samnang]

Done for changes. Do you have other things to me to look at before merging this?

[avdi]

You are awesome.