Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme in english #1857

Closed
avelino opened this issue Mar 24, 2018 · 9 comments
Closed

readme in english #1857

avelino opened this issue Mar 24, 2018 · 9 comments
Assignees
@PotHix @appleboy @dukex @matrixik @crgimenes @campoy @cassiobotaro @ianlancetaylor @felipeweb
Labels
help wanted suggestion

Comments

@avelino
Copy link
Owner

avelino commented Mar 24, 2018

ref: #1851 (review)

The above reference says it all, it seems to me a great project but do not understand the README to read more about the project.

My proposal is to put in the contribution guide that needs to have the README content in English (a common language for all)
@avelino avelino mentioned this issue Mar 24, 2018
Closed
7 tasks
@appleboy
Copy link
Collaborator

appleboy commented Mar 24, 2018 •
edited

agree + 1

@matrixik
Copy link
Contributor

Would you prefer entire README in English or there could be only part in English that say what this library is for?

@avelino
Copy link
Owner Author

avelino commented Apr 3, 2018

@matrixik For me it should be whole in English
What opinion of you?

@matrixik
Copy link
Contributor

matrixik commented Apr 6, 2018

@avelino After some thinking you are probably right. This list for English speaking user base. If library/tool is useful only to some specific lang/country there it probably should not be here.

@jtemporal
Copy link
Contributor

jtemporal commented Apr 18, 2018 •
edited

it should be whole in English

👍

@OrlovEvgeny
Copy link
Contributor

I suggest that the comments in the code should also be in English

@dmitshur dmitshur removed their assignment May 7, 2018
@ceriath
Copy link
Collaborator

ceriath commented Nov 9, 2018

will this ever be implemented to the contribution guidelines?

@avelino
Copy link
Owner Author

avelino commented Nov 9, 2018

will this ever be implemented to the contribution guidelines?

@ceriath we accept PR

@ceriath ceriath mentioned this issue Nov 9, 2018
Merged
@avelino
Copy link
Owner Author

avelino commented Nov 9, 2018

very very thanks @ceriath

@avelino avelino closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PotHix PotHix

@appleboy appleboy

@dukex dukex

@matrixik matrixik

@crgimenes crgimenes

@campoy campoy

@cassiobotaro cassiobotaro

@ianlancetaylor ianlancetaylor

@felipeweb felipeweb

Labels
help wanted suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests