Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name for the package geo_pattern #305

Closed
pravj opened this issue Mar 9, 2015 · 5 comments
Closed

Change name for the package geo_pattern #305

pravj opened this issue Mar 9, 2015 · 5 comments

Comments

@pravj
Copy link
Contributor

pravj commented Mar 9, 2015

Hi folks,

Although the package is already there in the list in images section.
But today I made some changes to the project that also involves renaming it to geoPattern. Actually I was trying my best to follow the new golang blog, Package Names

GitHub usually redirects renamed projects very well but I just felt like asking to you all.

So, is this fine to change name for it or not?

@mholt
Copy link
Contributor

mholt commented Mar 9, 2015

Yep! Thank you. Just keep it alphabetized and that'll be good! (Feel free to submit a PR)

@dmitshur
Copy link
Collaborator

I think it's absolutely fine to rename your package if you think it's better. You are the owner.

Actually I was trying my best to follow the new golang blog, Package Names

That page says the following:

Good package names are short and clear. They are lower case, with no under_scores or mixedCaps.

The style of names typical of another language might not be idiomatic in a Go program. Here are two examples of names that might be good style in other languages but do not fit well in Go:

  • computeServiceClient
  • priority_queue

I just want to point out, your new package name seems to be equally discouraged in that section like the old. Is that intentional?

@pravj
Copy link
Contributor Author

pravj commented Mar 10, 2015

Ohh my god.

This will obviously indicate that I was not functioning properly when I violated the rule, I wanted to follow.
Probably those golint errors, asking me to name underscored variables to CamelCase, made me do the same with package name.

Sorry, my fault. Feeling apologetic.

But a lesson learned.

I should have shown it to someone before really moving ahead with that desicion.

Thanks @shurcooL, for pointing this out.

So now, can somebody please suggest me, what to name it?
Is geopattern fine? It doesn't feel good as a single word though.

@dmitshur
Copy link
Collaborator

I think geopattern is fine. I am not a huge fan of it, but that's the recommended style.

@pravj
Copy link
Contributor Author

pravj commented Mar 10, 2015

Yeah! I'm also not a fan of this convention.
But I renamed it to geopattern as you suggested, seems like it was the only option.

All this, resulted in a nice version message though. 😄

v1.4.1 - The Namesake

Made a pull request #306 for it.

Thanks for the help everyone.

@pravj pravj closed this as completed Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants