Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two books to E-Books section #2056

Merged
merged 2 commits into from Aug 13, 2018
Merged

Add two books to E-Books section #2056

merged 2 commits into from Aug 13, 2018

Conversation

mrnugget
Copy link
Contributor

@mrnugget mrnugget commented Aug 7, 2018

Shameless self-promotion of my own books, but since the feedback was so positive so far, I thought someone would enjoy stumbling upon them in this list. Feel free to decline, though, if you don't want me to add my own links :)

TODOs:

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added godoc link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

Shameless self-promotion of my own books, but since the feedback was so positive so far, I thought someone would enjoy stumbling upon them in this list. Feel free to decline, though, if you don't want me to add my own links :)

**TODOs:**
- [x] I have added my package in alphabetical order.
- [x] I have an appropriate description with correct grammar.
- [x] I know that this package was not listed before.
- [x] I have added godoc link to the repo and to my pull request.
- [x] I have added coverage service link to the repo and to my pull request.
- [x] I have added goreportcard link to the repo and to my pull request.
- [x] I have read [Contribution guidelines](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#contribution-guidelines), [maintainers note](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#maintainers) and [Quality standard](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#quality-standard).
Copy link
Owner

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--- FAIL: TestAlpha/E-Books (0.00s)
        repo_test.go:118: expected 'writing a compiler in go' but actual is 'writing an interpreter in go'
        repo_test.go:118: expected 'writing an interpreter in go' but actual is 'writing a compiler in go'
        repo_test.go:122: expected order is:
            a go developer’s notebook
            an introduction to programming in go
            build web application with golang
            building web apps with go
            go 101
            go bootcamp
            gobooks
            learning go
            network programming with go
            the go programming language
            web application with go the anti-textbook
            writing a compiler in go
            writing an interpreter in go

@mrnugget
Copy link
Contributor Author

I reordered it. Thanks! Should I squash the commits locally or do you want to do that when merging?

@mrnugget
Copy link
Contributor Author

Thank you! 👍 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants