Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of the new README features #3558

Closed
wants to merge 7 commits into from
Closed

Take advantage of the new README features #3558

wants to merge 7 commits into from

Conversation

Joakker
Copy link

@Joakker Joakker commented Apr 6, 2021

Closes #3550
This PR takes advantage of the new Github features for auto generating the table of contents. It also adds emojis to every header in the document to make them distinguishable from one another

@avelino
Copy link
Owner

avelino commented Apr 6, 2021

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: False
  • coverage: False

your project is about to be approved, it's under revision, it may take a few days

@Joakker
Copy link
Author

Joakker commented Apr 6, 2021

I should also mention that the headers don't exactly map out to the emojis' meanings, since some of them were a bit too specific to find a suitable one, and some of them are duplicated, but in general, I tried to make the emoji be at least tangentially related in meaning to the title they correspond to.

README.md Show resolved Hide resolved
@Joakker
Copy link
Author

Joakker commented Apr 6, 2021

There, this seems to work well

Copy link
Owner

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the emoji in the prefix is breaking the test alphabetically, we have put at the end of the title

Check Travis-CI: https://travis-ci.com/github/avelino/awesome-go/builds/222335165

@avelino
Copy link
Owner

avelino commented Apr 9, 2021

@Joakker many links are broken, are you aware of this?

Can you keep working on this change?

@Joakker
Copy link
Author

Joakker commented Apr 9, 2021

I can. But most of the links work on my end, so I don't know what is going on

EDIT: I went through the links, and all of them seem to work well. Which ones do you have a problem in?

@github-actions
Copy link

This PR has been automatically marked as closed because it has not had recent activity. They will wait 15 days for your interaction, after that the PR will be closed. Please read more in https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md

@github-actions github-actions bot added the stale label Apr 25, 2021
@github-actions github-actions bot closed this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emoji on topicos (titles)
2 participants