-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reeflective/console #4682
base: main
Are you sure you want to change the base?
Add reeflective/console #4682
Conversation
Thank you for contributing with awesome-go, we will revise your contribution as soon as possible. Automation body links content check:
|
Bothering you twice with one stone @avelino ... Before anything, this library does not have any test suite. Closed-loop, "readline-style" applications are quite a niche market, but the latter suffers from both insufficiently featured readline libraries and the inability to interface with classic command libraries. The library advertised in this PR aims to bring a very easy to use console application that accepts spf13/cobra command trees. For this niche market, this library is one of the rare to exist, and probably the most advanced one publicly available. It is also the only one to interface perfectly with cobra command trees. Thanks for the time you will give ! Max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need test coverage working
@skydiver1980 read my comment? |
So after verification it seems to me that there are no coverage report as my repository does not include any tests. Currently, none are really needed, as the codebase is not only rather simple but moreover, simply "glueing" together other libraries (the most important ones being spf13/cobra and reeflective/readline), which have each significant testing suite and coverage. Maybe this is a deal breaker for this to be accepted, in which case I can't do anything but to wait for the moment my repository will really need a testing suite. On the other hand, allow me to reiterate that this library as quite useful to some niche applications, as well as being the only one in this field, and quite efficient at it. Thanks for the reviews anyway ! |
Please provide package links to:
Note: that new categories can be added only when there are 3 packages or more.
Make sure that you've checked the boxes below that apply before you submit PR.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.
Thanks for your PR, you're awesome! 👍