Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reeflective/console #4682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

maxlandon
Copy link
Contributor

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below that apply before you submit PR.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.
  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • The authors of the project do not commit directly to the repo, but rather use pull requests that run the continuous-integration process.

Thanks for your PR, you're awesome! 👍

@avelino
Copy link
Owner

avelino commented Jan 8, 2023

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: True
  • coverage: True

your project is about to be approved, it's under revision, it may take a few days

@maxlandon maxlandon mentioned this pull request May 29, 2023
10 tasks
@maxlandon
Copy link
Contributor Author

maxlandon commented Sep 2, 2023

Bothering you twice with one stone @avelino ...

Before anything, this library does not have any test suite.
It is a big blocker for big projects (understandably), but this library currently is not large enough to justify one. It will probably include one to reach v1.0.0. Just saying if you keep reading below.

Closed-loop, "readline-style" applications are quite a niche market, but the latter suffers from both insufficiently featured readline libraries and the inability to interface with classic command libraries.

The library advertised in this PR aims to bring a very easy to use console application that accepts spf13/cobra command trees.
In turn, it provides all the comfort of life features and improvements commonly found in our modern shells, while providing full bash inputrc support (config/binds/commands).

For this niche market, this library is one of the rare to exist, and probably the most advanced one publicly available.

It is also the only one to interface perfectly with cobra command trees.
Some people might be interested as well !

Thanks for the time you will give !

Max

Copy link
Owner

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need test coverage working

@avelino
Copy link
Owner

avelino commented Nov 24, 2023

@skydiver1980 read my comment?

need test coverage, today not working
IMG_7783

@maxlandon
Copy link
Contributor Author

maxlandon commented Dec 4, 2023

So after verification it seems to me that there are no coverage report as my repository does not include any tests.

Currently, none are really needed, as the codebase is not only rather simple but moreover, simply "glueing" together other libraries (the most important ones being spf13/cobra and reeflective/readline), which have each significant testing suite and coverage.

Maybe this is a deal breaker for this to be accepted, in which case I can't do anything but to wait for the moment my repository will really need a testing suite.

On the other hand, allow me to reiterate that this library as quite useful to some niche applications, as well as being the only one in this field, and quite efficient at it.

Thanks for the reviews anyway !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants