Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update max verse counts #162

Merged
merged 2 commits into from
May 23, 2024
Merged

update max verse counts #162

merged 2 commits into from
May 23, 2024

Conversation

avendesora
Copy link
Owner

@avendesora avendesora commented May 23, 2024 •
edited
Loading

Description

update max verse counts based on chapter/verse info from multiple versions/translations

Checklist:

  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run pre-commit locally prior to submission and fixed any errors/warnings.
  • I have run tests locally prior to submission and they are passing.
  • I have added necessary documentation (if appropriate).
  • I have updated the README (if appropriate).
  • I have updated the CHANGELOG (if appropriate).
  • I have updated the version number (if appropriate).
  • I have updated the requirements (if appropriate).

sourcery-ai[bot]
sourcery-ai bot reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@avendesora avendesora merged commit ab668b7 into main May 23, 2024
7 checks passed
@avendesora avendesora deleted the update-chapter-max-verses branch May 23, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@avendesora