Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve buffer options #749

Merged
merged 13 commits into from
Aug 16, 2023
Merged

improve buffer options #749

merged 13 commits into from
Aug 16, 2023

Conversation

johakoch
Copy link
Collaborator

JSON parse backend requests/responses only where necessary (.json_body used)

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch linked an issue Mar 28, 2023 that may be closed by this pull request
Improve BufferOptions (body, json_body) #680
Closed
@johakoch johakoch marked this pull request as ready for review March 31, 2023 13:26
@malud malud force-pushed the 680-improve-buffer-options branch from a596359 to 1817311 Compare May 16, 2023 07:26
malud
malud previously approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@malud malud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added methods to determine the current buffer options so we have them in one place. Also finalised the request.json_body question. Please review my changes @johakoch .

eval/context.go Outdated Show resolved Hide resolved
@malud malud force-pushed the 680-improve-buffer-options branch from 72046b4 to c6eaf8f Compare May 16, 2023 08:21
@malud malud force-pushed the 680-improve-buffer-options branch from c6eaf8f to 481ba00 Compare May 16, 2023 10:43
@johakoch johakoch force-pushed the 680-improve-buffer-options branch from f430e5d to ea7197a Compare May 16, 2023 14:44
@malud malud merged commit 8152b0d into master Aug 16, 2023
1 check passed
@malud malud deleted the 680-improve-buffer-options branch August 16, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees

@malud malud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve BufferOptions (body, json_body)
2 participants
@johakoch @malud