Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPv6 support #752

Merged
merged 11 commits into from
Feb 1, 2024
Merged

Add IPv6 support #752

merged 11 commits into from
Feb 1, 2024

Conversation

alex-schneider
Copy link
Contributor

Describe your changes!

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

johakoch
johakoch reviewed Apr 3, 2023
View reviewed changes
server/http.go Outdated Show resolved Hide resolved
@johakoch johakoch linked an issue Apr 3, 2023 that may be closed by this pull request
remove ipv6 restrictions #683
Closed
johakoch
johakoch reviewed Apr 4, 2023
View reviewed changes
config/settings.go Outdated Show resolved Hide resolved
malud
malud approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@malud malud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with -bind-address :: and logs showed client_ip="::1" with localhost. Also ipv4 in logs while calling ipv4 (127.0.0.1).

@malud malud merged commit 21688cd into master Feb 1, 2024
2 checks passed
@malud malud deleted the 683-ipv6 branch February 1, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch left review comments

@malud malud malud approved these changes

Assignees

@malud malud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove ipv6 restrictions
3 participants
@alex-schneider @malud @johakoch