Ensure we only have one git processing running in parallel #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindelleric
reviewed
Apr 28, 2022
src/git.ts
Outdated
| return result.stdout.trim(); | ||
| async function git(args: string[], cwd: string | undefined) { | ||
| if (currentCommand) { | ||
| await currentCommand; |
There was a problem hiding this comment.
Wouldn't this just allow the first git command to be run separately, and then the rest all at once? 🤔 Or at least all the ones that were called before the first currentCommand has resolved.
There was a problem hiding this comment.
That's very true! Nice catch, brain fart from me there. 😄 Fixed now!
andersekdahl
force-pushed
the
no-parallel-git
branch
from
0a64e7b
to
1268e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mutex to ensure that we don't run multiple git commands in parallel. Running multiple git commands in parallel is fine on most machines and OSes, but I recently had really wierd issues when trying to do so with the Node Alpine docker image. Git would respond, but not with the correct data. Once I ensured that we only called
version.getCurrentVersion()once at a time the issue went away.So this PR makes sure that we're "safe by defaut". It does mean that if you query git a lot it's going to be slightly slower because we no longer do it in parallel but I don't think that matters as I don't know of any use case where we'd want to call git in parallel like that.