Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line ending issue in tests #16

Closed
wants to merge 1 commit into from
Closed

Conversation

erik-kallen
Copy link
Collaborator

Build should no longer fail due to CR/LF differences

Copy link
Contributor

@csi-lund csi-lund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Eric - Vabbing today but not sure this is the right solution to change the tests - see discussion in the below thread.

#7

Re builds they do work on the GitHub actions - it's usually only locally they fail. The test files that are read have deliberately been committed with specific line endings by Anders. We suspected that it's most likely git overriding settings that seem to be causing the failures - it's odd though that the .gitattributes hasn't resolved this for people locally - is this a fresh clone of the repo or have you had it previously - I've heard some stories about git caches not updating

@erik-kallen
Copy link
Collaborator Author

I have no idea why, but I know that this fix will fix the problem whatever line endings are checked out, and I can't see when making this change would ever cause any kind of problem

@csi-lund
Copy link
Contributor

csi-lund commented Jun 22, 2022

I have no idea why, but I know that this fix will fix the problem whatever line endings are checked out, and I can't see when making this change would ever cause any kind of problem

I've run the tests on master on windows, via VS and using the dotnet command. I even got a college to run it on linux and they pass, plus the actions build so for me its suggest the root cause is the line endings settings not being picked up. Ill try to move the .gitattributes up to root from the test project and we can see if this will fix it. Try pulling main or remove the repo and re cloning it to see if that resolved it. I dont think we should change the test data and result to match because imo that is treating the symptom not the cause.

For now I will close this.

@csi-lund csi-lund closed this Jun 22, 2022
@erik-kallen
Copy link
Collaborator Author

It wasn't me who had a problem with it, it was Johan Book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants