Skip to content

Commit

Permalink
SIScalar and FloatSIScalar of() accepts empty unit string
Browse files Browse the repository at this point in the history
  • Loading branch information
averbraeck committed Jul 23, 2023
1 parent 7f22737 commit b329b7b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions src/main/resources/value/vdouble/scalar/SISCALAR.java
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ public SIScalar reciprocal()
public static SIScalar valueOf(final String text)
{
Throw.whenNull(text, "Error parsing SIScalar: unitString is null");
Throw.when(text.length() == 0, IllegalArgumentException.class, "Error parsing SIScalar: empty unitString");
Throw.when(text.length() == 0, IllegalArgumentException.class, "Error parsing SIScalar: empty string");
try
{
NumberParser numberParser = new NumberParser().lenient().trailing();
Expand Down Expand Up @@ -196,7 +196,6 @@ public static SIScalar valueOf(final String text)
public static SIScalar of(final double value, final String unitString)
{
Throw.whenNull(unitString, "Error parsing SIScalar: unitString is null");
Throw.when(unitString.length() == 0, IllegalArgumentException.class, "Error parsing SIScalar: empty unitString");
try
{
SIUnit unit = Unit.lookupOrCreateUnitWithSIDimensions(SIDimensions.of(unitString));
Expand Down
3 changes: 1 addition & 2 deletions src/main/resources/value/vfloat/scalar/FLOATSISCALAR.java
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public FloatSIScalar reciprocal()
public static FloatSIScalar valueOf(final String text)
{
Throw.whenNull(text, "Error parsing SIScalar: unitString is null");
Throw.when(text.length() == 0, IllegalArgumentException.class, "Error parsing SIScalar: empty unitString");
Throw.when(text.length() == 0, IllegalArgumentException.class, "Error parsing SIScalar: empty string");
try
{
NumberParser numberParser = new NumberParser().lenient().trailing();
Expand Down Expand Up @@ -195,7 +195,6 @@ public static FloatSIScalar valueOf(final String text)
public static FloatSIScalar of(final float value, final String unitString)
{
Throw.whenNull(unitString, "Error parsing FloatSIScalar: unitString is null");
Throw.when(unitString.length() == 0, IllegalArgumentException.class, "Error parsing FloatSIScalar: empty unitString");
try
{
SIUnit unit = Unit.lookupOrCreateUnitWithSIDimensions(SIDimensions.of(unitString));
Expand Down

0 comments on commit b329b7b

Please sign in to comment.