Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add critical hits when rolling damage #89

Open
averycrespi opened this issue Aug 31, 2020 · 0 comments
Open

Add critical hits when rolling damage #89

averycrespi opened this issue Aug 31, 2020 · 0 comments
Assignees
Labels
feature New feature

Comments

@averycrespi
Copy link
Owner

averycrespi commented Aug 31, 2020

Changes:

  • When a DAMAGE button is Control-clicked, the roll should be treated as a critical hit
  • The toast message should be changed to: "$character rolled critical $weapon damage!"
  • The emote should be changed to: "/em : $character rolls critical $weapon damage"
  • All damage dice (not modifiers) should be doubled. Example: 1d4 + 2 becomes 2d4 + 2
  • A tooltip should be added to the buttons, which says: ctrl+click for critical hit

Notes;

  • Extract the dice using the following regex: [0-9]+d[0-9]+, split on the d, double, then recombine
  • We need to wait for Support compact roll buttons #88 to avoid redoing work
@averycrespi averycrespi added the feature New feature label Aug 31, 2020
@averycrespi averycrespi self-assigned this Aug 31, 2020
@averycrespi averycrespi modified the milestone: v1.4.0 Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant