atom-elm-format guideline changes

[benjick]

Since 2.0 the default is to format on save 🎉

[avh4]

Great, thanks for the update!

[avh4]

@benjick I actually just reverted this.... having format-on-save be the default is the existing checkmark in the "Format on Save" column.

The warning in the "Formatting" column is because is because of this (#104):

When formatting a file, if the in-memory version of the file and the on-disk version of the file differ, then the plugin should format the in-memory version of the file. (Saving the file before formatting is also acceptable.)

The behavior when I tested it was that if format-on-save is turned off and the file is not saved before running the manual formatting command, then there are some problems.

[benjick]

Oh okay, now I understand. Sorry about that. I will look into making it
compatible.

Which is preferred? Saving the file or just replacing the buffer?

On 31 Aug 2016 19:33, "Ɛərɪn VonderHaar" notifications@github.com wrote:

@benjick https://github.com/benjick I actually just reverted this....
having format-on-save be the default is the existing checkmark in the
"Format on Save" column.

The warning in the "Formatting" column is because is because of this:

When formatting a file, if the in-memory version of the file and the
on-disk version of the file differ, then the plugin should format the
in-memory version of the file. (Saving the file before formatting is also
acceptable.)

The behavior when I tested it was that if format-on-save is turned off and
the file is not saved before running the manual formatting command, then
there are some problems.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#225 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAaTGGvNTc14ES4beyW41BNI7X2IF6tAks5qlbrMgaJpZM4Jt4to
.

[benjick]

Okay I read the guidelines now, will look into this!

[avh4]

@benjick I assumed different things might be conventional for different editors, so didn't want to dictate that. Maybe check out popular atom formatting plugins for other languages and see what's common?

[benjick]

The thing I do now I borrowed from eslint, but I think it's more important
to be compliant with the plug-in itself, than other plug-ins for the editor

On 31 Aug 2016 20:48, "Ɛərɪn VonderHaar" notifications@github.com wrote:

@benjick https://github.com/benjick I assumed different things might be
conventional for different editors, so didn't want to dictate that. Maybe
check out popular atom formatting plugins for other languages and see
what's common?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#225 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAaTGI0uetrTgDDPhtXdKzgWG0jHQ2jjks5qlcs2gaJpZM4Jt4to
.