Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and clarify VSCode installation instructions. #597

Merged
merged 1 commit into from Aug 4, 2019

Conversation

judytuna
Copy link
Contributor

@judytuna judytuna commented Feb 24, 2019

I'm assuming people know where to find the Extensions menu in VSCode, and how to download the extension named elm.

I'm also assuming people won't already have a field visible in the UI for VSCode settings called "[elm]" that is editable in the UI, so we're going to have to open up settings.json and add the field manually. I've linked to the VSCode docs, which will tell you where to find your settings.json file based on your operating system.

I don't want people to copy-and-paste the json outside of the {}. I wanted to say something like "add this somewhere in the top level of your json blob" but thought that would just be confusing--they might misunderstand and think I'm saying "top of the file," but all I'm trying to say is "within the outermost { and }". So I kept the wording very simple. What do you think?

Thank you for ElmBridge!!

@avh4 avh4 added this to the 0.8.2 CLI updates milestone Jul 27, 2019
@avh4 avh4 merged commit 3c1b601 into avh4:master Aug 4, 2019
@avh4
Copy link
Owner

avh4 commented Aug 4, 2019

Looks good -- thanks for the explanations!

kutyel pushed a commit to kutyel/elm-format that referenced this pull request Apr 26, 2022
Update and clarify VSCode installation instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants