Parsec API refactor #743
Merged
Parsec API refactor #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better long term to store notes directly in the source instead of a markdown file.
emmabastas
force-pushed
the
new-parser-2021-refactor
branch
from
5caea19
to
8d325a8
Compare
kutyel
pushed a commit
to kutyel/elm-format
that referenced
this pull request
Apr 26, 2022
Parsec API refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring of the parsec-like API, including the "documentation" in
new-parser-2021-notes.mdParsec-like API refactor
All of the modules providing the parsec-like API are merged into one single module. I.e. all functions found in
Text.*are moved intoParse.ParsecAdapter. This means that all modules using the parsec-like API have had import statements changed resulting in the large file change count for this PR."Documentation" refactor
Notes found in
new-parser-2021-notes.mdwhich have been taken during the course of the parsec-like API work have been moved to more appropriate places, like source code comments and a Github issue, and the document has been removed.Behavioral changes
The only change to the behavior of the parsec-like API can be found in bc58b34, a minor fix to the error message of a function.
Other refactorings
Parse.Helpers.failurehas been re-implemented without the use ofgetInputandsetInput, so that they can be removed from the API. This functions was re-implemented in elm/compiler at one point as well: https://github.com/elm/compiler/blob/9f6c60cec62a21f8eb205949f7a7115b60fd5832/src/Parse/Primitives.hs#L100